Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.7] Fix for ReportQuery not fetching relationships with BatchFetch.IN #2316

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Sheikah45
Copy link
Contributor

Backport of #2303

@Sheikah45
Copy link
Contributor Author

I tried to add the test classes in but wasn't sure where the persistence.xml was supposed to go

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

persistence.xml should be under new folder eclipselink-batchfetch-model
in
https://github.com/eclipse-ee4j/eclipselink/tree/2.7/jpa/eclipselink.jpa.test/resource
NOTE: Don't forget if there are some jakarta.persistence properties to rename into javax.persistence and XML Schema should be same as
https://github.com/eclipse-ee4j/eclipselink/blob/2.7/jpa/eclipselink.jpa.test/resource/eclipselink-beanvalidation-model/persistence.xml
<persistence xmlns="http://java.sun.com/xml/ns/persistence" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/persistence persistence_2_0.xsd" version="2.0">

Plus changes in
https://github.com/eclipse-ee4j/eclipselink/blob/2.7/jpa/eclipselink.jpa.test/antbuild.xml
https://github.com/eclipse-ee4j/eclipselink/blob/2.7/jpa/eclipselink.jpa.test/antbuild.properties
but just modify java part plus add persistence.xml I'll handle Ant build scripts.

@rfelcman
Copy link
Contributor

See Sheikah45#2

Copy link
Contributor

@rfelcman rfelcman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rfelcman rfelcman merged commit 2db4798 into eclipse-ee4j:2.7 Nov 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants